Skip to content

[DOCS] Remove delimited block for Asciidoctor migration#41582

Merged
jrodewig merged 1 commit intoelastic:masterfrom
jrodewig:asciidoctor-rolling-upgrades
Apr 26, 2019
Merged

[DOCS] Remove delimited block for Asciidoctor migration#41582
jrodewig merged 1 commit intoelastic:masterfrom
jrodewig:asciidoctor-rolling-upgrades

Conversation

@jrodewig
Copy link
Copy Markdown
Contributor

@jrodewig jrodewig commented Apr 26, 2019

In Asciidoctor, this delimited block resets the nested ordered list (changing d to a). This removes the block, which wasn't needed anyway.

Before/After Images in Asciidoctor

Before
asciidoctor-before

After
asciidoctor-after

@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-docs

Copy link
Copy Markdown
Member

@nik9000 nik9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM so long as this still works in AsciiDoc too.

@jrodewig
Copy link
Copy Markdown
Contributor Author

Thanks @nik9000.

Here's how it outputs in AsciiDoc:
asciidoc-render

Copy link
Copy Markdown
Member

@nik9000 nik9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@jrodewig jrodewig merged commit ce59d45 into elastic:master Apr 26, 2019
@jrodewig jrodewig deleted the asciidoctor-rolling-upgrades branch April 26, 2019 16:16
@jaymode jaymode added v7.0.1 and removed v7.0.2 labels Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants