Remove Exists Check from S3 Repository Deletes (#40931)#41534
Merged
original-brownbear merged 1 commit intoelastic:7.xfrom Apr 25, 2019
original-brownbear:40931-7.x
Merged
Remove Exists Check from S3 Repository Deletes (#40931)#41534original-brownbear merged 1 commit intoelastic:7.xfrom original-brownbear:40931-7.x
original-brownbear merged 1 commit intoelastic:7.xfrom
original-brownbear:40931-7.x
Conversation
* The check doesn't add much if anything practically, since the S3 repository is eventually consistent and we only log the non-existence of a blob anyway * We don't do the check on writes for this very reason and documented it as such * Removing the check saves one API call per single delete speeding up the deletion process and lowering costs
Collaborator
|
Pinging @elastic/es-distributed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of #40931