Name Snapshot Data Blobs by UUID (#40652)#41523
Merged
original-brownbear merged 1 commit intoelastic:7.xfrom Apr 25, 2019
original-brownbear:40652-7.x
Merged
Name Snapshot Data Blobs by UUID (#40652)#41523original-brownbear merged 1 commit intoelastic:7.xfrom original-brownbear:40652-7.x
original-brownbear merged 1 commit intoelastic:7.xfrom
original-brownbear:40652-7.x
Conversation
* Name Snapshot Data Blobs by UUID * There is no functional reason why we need incremental naming for these files but * As explained in #38941 it is a possible source of corrupting the repository * It wastes API calls for the list operation * Is just needless complication * Since we store the exact names of the data blobs in all the metadata anyway, we can make this change without any BwC considerations * Even on the worst case scenario of a downgrade the functionality would continue working since the incremental names wouldn't conflict with the uuids and the number parsing for finding the next incremental name suppresses the exception when encountring a non-numeric value after the double underscore prefix
Collaborator
|
Pinging @elastic/es-distributed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Name Snapshot Data Blobs by UUID
There is no functional reason why we need incremental naming for these files but
Since we store the exact names of the data blobs in all the metadata anyway, we can make this change without any BwC considerations
backport of #40652