[DOCS] Specify ID for string field replacement section of 5.0 breaking changes#41506
Merged
jrodewig merged 1 commit intoelastic:5.6from Apr 24, 2019
jrodewig:fix-asciidoctor-errors-string-mapping
Merged
[DOCS] Specify ID for string field replacement section of 5.0 breaking changes#41506jrodewig merged 1 commit intoelastic:5.6from jrodewig:fix-asciidoctor-errors-string-mapping
jrodewig merged 1 commit intoelastic:5.6from
jrodewig:fix-asciidoctor-errors-string-mapping
Conversation
Collaborator
|
Pinging @elastic/es-docs |
string replacement section of 5.0 breaking changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the 5.x version of the Elasticsearch.Net docs, the NEST Breaking Changes page links to an auto-generated anchor in the 5.6 Elasticsearch reference.
This is bad practice generally, but the link breaks in Asciidoctor. This PR adds the anchor to Elasticsearch reference so the Elasticsearch.Net link does not break during Asciidoctor migration.
Relates to #41128 and elastic/docs#827.