Skip to content

SQL: Upgrade H2GIS library to 1.5.0#40461

Merged
imotov merged 1 commit intoelastic:geosqlfrom
imotov:geosql-h2gis-150
Mar 27, 2019
Merged

SQL: Upgrade H2GIS library to 1.5.0#40461
imotov merged 1 commit intoelastic:geosqlfrom
imotov:geosql-h2gis-150

Conversation

@imotov
Copy link
Copy Markdown
Contributor

@imotov imotov commented Mar 26, 2019

Upgrades H2GIS to 1.5.0, restores H2 version to 1.4.197 and removes
work-around for bugs in H2 1.4.196 and jar conflicts in H2GIS 1.3.2.

Upgrades H2GIS to 1.5.0, restores H2 version to 1.4.197 and removes
work-around for bugs in H2 1.4.196 and jar conflicts in H2GIS 1.3.2.
@imotov imotov added >enhancement :Analytics/Geo Indexing, search aggregations of geo points and shapes :Analytics/SQL SQL querying v8.0.0 labels Mar 26, 2019
@imotov imotov requested review from alpar-t, astefan, costin and matriv March 26, 2019 14:07
@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-analytics-geo

@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-search

Copy link
Copy Markdown
Member

@costin costin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM



// H2GIS testing dependencies
compile ("org.orbisgis:h2gis:1.5.0") {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opt for externalizing h2gis (and h2 while at it) versions into a central place (like jlineVersion), namely build.gradleundersql`:

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I will do that in master first and then make corresponding changes in the branch after merging

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opened #40551 to address this in master. I will fix it for h2gis when I merge master into geosql branch.

Copy link
Copy Markdown
Contributor

@matriv matriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@astefan astefan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imotov imotov merged commit 1ad9d0b into elastic:geosql Mar 27, 2019
@elasticmachine elasticmachine mentioned this pull request Apr 10, 2019
13 tasks
@imotov imotov removed the v8.0.0 label Apr 24, 2019
@imotov imotov deleted the geosql-h2gis-150 branch May 1, 2020 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Analytics/Geo Indexing, search aggregations of geo points and shapes :Analytics/SQL SQL querying >enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants