[ML] add auditor to data frame plugin (#40012)#40394
Merged
benwtrent merged 1 commit intoelastic:7.xfrom Mar 23, 2019
Merged
Conversation
* [Data Frame] add auditor * Adjusting Level, Auditor, and message to address pr comments * Addressing PR comments
Collaborator
|
Pinging @elastic/ml-core |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a DataFrameAuditor, a index for audit messages, and an audit messages class.
I took the basic functionality found in the ML Auditor, and created two new abstract classes in
org.elasticsearch.xpack.core.common.notifications for consolidating what would be commonalities between any plugin using an Auditor-like system.
I opted to simply copy the Level class found in the ml notifications package. I thought it best do any refactoring for ML in a different PR.
As for what to audit and when, that question is still up in the air, but at least after this PR that functionality will be available.