Skip to content

[ML-DataFrame] Add support for (date) histogram pivots#38725

Merged
benwtrent merged 4 commits intoelastic:feature/fibfrom
benwtrent:feature/ml-dataframe-add-histo-pivot
Feb 11, 2019
Merged

[ML-DataFrame] Add support for (date) histogram pivots#38725
benwtrent merged 4 commits intoelastic:feature/fibfrom
benwtrent:feature/ml-dataframe-add-histo-pivot

Conversation

@benwtrent
Copy link
Copy Markdown
Member

This adds support for (date) histogram pivots.

These pivots are formatted to allow the same functionality currently available in composite aggregations.

@benwtrent benwtrent added >feature :ml Machine learning labels Feb 11, 2019
@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/ml-core


// we expect 17 documents as there shall be 21 days worth of docs
Map<String, Object> indexStats = getAsMap(dataFrameIndex + "/_stats");
assertEquals(21, XContentMapValues.extractValue("_all.total.docs.count", indexStats));
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: comment says 17

Copy link
Copy Markdown

@hendrikmuhs hendrikmuhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benwtrent benwtrent merged commit cedd78c into elastic:feature/fib Feb 11, 2019
@benwtrent benwtrent deleted the feature/ml-dataframe-add-histo-pivot branch February 11, 2019 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>feature :ml Machine learning

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants