Fix AnalysisModuleTests#testStandardFilterBWC#38638
Merged
cbuescher merged 1 commit intoelastic:masterfrom Feb 11, 2019
Merged
Conversation
The part of this test that has been checking deprecation warnings on pre-7.0 nodes doesn't work anymore on 8.0 and must be removed. Closes elastic#38635
Collaborator
|
Pinging @elastic/es-search |
romseygeek
reviewed
Feb 8, 2019
| Settings settings = Settings.builder() | ||
| .put("index.analysis.analyzer.my_standard.tokenizer", "standard") | ||
| Version version = VersionUtils.randomVersionBetween(random(), Version.V_7_0_0, Version.CURRENT); | ||
| final Settings settings = Settings.builder().put("index.analysis.analyzer.my_standard.tokenizer", "standard") |
Contributor
There was a problem hiding this comment.
The standard tokenizer is still there, I think? You need to add index.analysis.analyzer.my_standard.filter=standard
Contributor
There was a problem hiding this comment.
Oh, never mind, it's still there - ignore me.
romseygeek
approved these changes
Feb 8, 2019
Contributor
romseygeek
left a comment
There was a problem hiding this comment.
LGTM, sorry for the misread in my review.
Member
Author
|
@elasticmachine run elasticsearch-ci/2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The part of this test that has been checking deprecation warnings on pre-7.0
nodes doesn't work anymore on 8.0 and must be removed.
Closes #38635