testHlrcFromXContent() should respect assertToXContentEquivalence()#38453
Merged
polyfractal merged 2 commits intoelastic:6.7from Feb 8, 2019
Merged
testHlrcFromXContent() should respect assertToXContentEquivalence()#38453polyfractal merged 2 commits intoelastic:6.7from
polyfractal merged 2 commits intoelastic:6.7from
Conversation
Tests can override assertToXContentEquivalence() in case their xcontent cannot be directly compared (e.g. due to insertion order in maps affecting the xcontent ordering). But the `testHlrcFromXContent` test hardcoded the equivalence test to `true` instead of consulting `assertToXContentEquivalence()` Fixes elastic#36034 Backport of elastic#38232
Collaborator
|
Pinging @elastic/es-core-features |
javanna
approved these changes
Feb 6, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests can override assertToXContentEquivalence() in case their xcontent cannot be directly compared (e.g. due to insertion order in maps affecting the xcontent ordering). But the
testHlrcFromXContenttest hardcoded the equivalence test totrueinstead of consultingassertToXContentEquivalence()Fixes #36034
Backport of #38232