Reenable MonitoringIT.testMonitoringService#38332
Conversation
|
Pinging @elastic/es-core-features |
|
Test is green, let's run it again: @elasticmachine run elasticsearch-ci/2 |
2 similar comments
|
Test is green, let's run it again: @elasticmachine run elasticsearch-ci/2 |
|
Test is green, let's run it again: @elasticmachine run elasticsearch-ci/2 |
|
Test is red but this is unrelated to this change, let's run it again: @elasticmachine run elasticsearch-ci/2 |
1 similar comment
|
Test is red but this is unrelated to this change, let's run it again: @elasticmachine run elasticsearch-ci/2 |
|
Test is green, let's run it again: @elasticmachine run elasticsearch-ci/2 |
1 similar comment
|
Test is green, let's run it again: @elasticmachine run elasticsearch-ci/2 |
|
Given the facts that this pull request got many successful builds and that the other test in the same class does not fail, I think we can reenable the muted test and see how it goes. Can anyone from the @elastic/es-core-features team review this please? |
| @@ -374,9 +374,6 @@ private void assertClusterStatsMonitoringDoc(final Map<String, Object> document, | |||
| assertThat(clusterState.remove("cluster_uuid"), notNullValue()); | |||
| assertThat(clusterState.remove("master_node"), notNullValue()); | |||
| assertThat(clusterState.remove("nodes"), notNullValue()); | |||
There was a problem hiding this comment.
Curious to why we are removing these assertions ?
There was a problem hiding this comment.
I think it's been added for Zen 2 but removed afterwards, but not noticed since the test was muted.
|
@elasticmachine run elasticsearch-ci/1 |
|
Thanks @jakelandis ! I merged this pull request and I'm going to let it run on CI/master for a few days before backporting the change to other branches. |
|
Removing the |
This pull request reenables the test
MonitoringIT.testMonitoringServiceand gives it a bit more time to start. This is curious that the testtestMonitoringBulkpasses and not this one, so I'm opening this pull request and I'll give it many CI builds to see if it fails a lot or not.Closes #29880