Deprecate implicit security on trial licenses#38295
Merged
tvernum merged 1 commit intoelastic:6.xfrom Feb 5, 2019
Merged
Conversation
In 6.x security is implicitly enabled on a trial license if transport SSL is enabled, or the trial is from pre-6.3. This is no longer true on 7.0, so this behaviour is now deprecated. Relates: elastic#38009, elastic#38075
Collaborator
|
Pinging @elastic/es-security |
26 tasks
AthenaEryma
reviewed
Feb 4, 2019
Contributor
AthenaEryma
left a comment
There was a problem hiding this comment.
The deprecation check part of this LGTM. I also don't see any issues with the rest of it, but I'm not very familiar with that code.
Thanks again, @tvernum!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In 6.x security is implicitly enabled on a trial license if transport
SSL is enabled, or the trial is from pre-6.3.
This is no longer true on 7.0, so this behaviour is now deprecated.
Relates: #38009, #38075