Add API key settings documentation#38164
Closed
bizybot wants to merge 3 commits intoelastic:security_api_keysfrom
Closed
Add API key settings documentation#38164bizybot wants to merge 3 commits intoelastic:security_api_keysfrom
bizybot wants to merge 3 commits intoelastic:security_api_keysfrom
Conversation
We have documented in our get token API that the configured maximumvalue for token expiry is 1 hour but that was not enforced. This commit fixes the setting and adds some missing API key service settings documentation.
Collaborator
|
Pinging @elastic/es-security |
Contributor
Author
|
@elasticmachine run elasticsearch-ci/default-distro |
jaymode
requested changes
Feb 1, 2019
Member
jaymode
left a comment
There was a problem hiding this comment.
We need to separate the token expiry change since it should probably be backported and is unrelated to API keys
x-pack/plugin/security/src/main/java/org/elasticsearch/xpack/security/authc/TokenService.java
Outdated
Show resolved
Hide resolved
- Created another PR for settings change in token service
Contributor
Author
|
Closing this in favor of #38490 to be merged to master. Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds missing
API key service settings documentation.