Deprecate xpack.watcher.history.cleaner_service.enabled#37782
Merged
dakrone merged 2 commits intoelastic:masterfrom Jan 24, 2019
Merged
Deprecate xpack.watcher.history.cleaner_service.enabled#37782dakrone merged 2 commits intoelastic:masterfrom
dakrone merged 2 commits intoelastic:masterfrom
Conversation
This deprecates the `xpack.watcher.history.cleaner_service.enabled` setting, since all newly created `.watch-history` indices in 7.0 will use ILM to manage their retention. In 8.0 the setting itself and cleanup actions will be removed. Resolves elastic#32041
Collaborator
|
Pinging @elastic/es-core-features |
Contributor
|
Could you also add a deprecation check for this setting? |
Member
Author
|
@gwbrown not sure what you mean exactly? Marking the setting as deprecated I believe causes logging for deprecation when the setting is set |
Contributor
AthenaEryma
approved these changes
Jan 24, 2019
Contributor
AthenaEryma
left a comment
There was a problem hiding this comment.
LGTM - After discussion with @dakrone we've decided to not add a deprecation check to this PR as it will likely be addressed by other planned improvements to the Deprecations API.
80 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This deprecates the
xpack.watcher.history.cleaner_service.enabledsetting,since all newly created
.watch-historyindices in 7.0 will use ILM to managetheir retention.
In 8.0 the setting itself and cleanup actions will be removed.
Resolves #32041