Remove more include_type_name and types from docs#37601
Merged
cbuescher merged 2 commits intoelastic:masterfrom Jan 18, 2019
Merged
Remove more include_type_name and types from docs#37601cbuescher merged 2 commits intoelastic:masterfrom
cbuescher merged 2 commits intoelastic:masterfrom
Conversation
Collaborator
|
Pinging @elastic/es-search |
markharwood
reviewed
Jan 18, 2019
Contributor
markharwood
left a comment
There was a problem hiding this comment.
One comment otherwise LGTM
| <3> Specify fields or _properties_. | ||
| <4> Specify the data `type` and mapping for each field. | ||
| <2> Specify fields or _properties_. | ||
| <3> Specify the data `type` and mapping for each field. |
Member
Author
There was a problem hiding this comment.
callout <4> was deleted (actually <2> was deleted and everything else moved up)
Member
Author
There was a problem hiding this comment.
Corrected the remaining offenting <4> Callout
Member
Author
|
@elasticmachine test this please |
markharwood
approved these changes
Jan 18, 2019
48 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #37568.
Use of
?include_type_name=truein docs on index creation down to ~120.