Remove the use of AbstracLifecycleComponent constructor Backport#37488#37522
Merged
pgomulka merged 3 commits intoelastic:6.xfrom Jan 17, 2019
Merged
Remove the use of AbstracLifecycleComponent constructor Backport#37488#37522pgomulka merged 3 commits intoelastic:6.xfrom
pgomulka merged 3 commits intoelastic:6.xfrom
Conversation
…elastic#37488) The AbstracLifecycleComponent used to extend AbstractComponent, so it had to pass settings to the constractor of its supper class. It no longer extends the AbstractComponent so there is no need for this constructor There is also no need for AbstracLifecycleComponent subclasses to have Settings in their constructors if they were only passing it over to super constructor. This is part 1. which will be backported to 6.x with a migration guide/deprecation log. part 2 will have this constructor removed in 7 relates elastic#35560 relates elastic#34488
Collaborator
|
Pinging @elastic/es-core-infra |
danielmitterdorfer
approved these changes
Jan 16, 2019
Member
danielmitterdorfer
left a comment
There was a problem hiding this comment.
LGTM. I left a minor comment around the Javadoc that explains the deprecation.
server/src/main/java/org/elasticsearch/common/component/AbstractLifecycleComponent.java
Show resolved
Hide resolved
Contributor
Author
|
run the gradle build tests 1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The AbstracLifecycleComponent used to extend AbstractComponent, so it had to pass settings to the constractor of its supper class.
It no longer extends the AbstractComponent so there is no need for this constructor
There is also no need for AbstracLifecycleComponent subclasses to have Settings in their constructors if they were only passing it over to super constructor.
This is part 1. which will be backported to 6.x with a migration guide/deprecation log.
part 2 will have this constructor removed in 7
relates #35560
relates #34488
gradle check?