Make sure to use the resolved type in DocumentMapperService#extractMappings.#37451
Merged
jtibshirani merged 2 commits intoelastic:masterfrom Jan 15, 2019
Merged
Conversation
…ppings. * Pull out a shared method MapperService#resolveDocumentType. * Make sure to resolve the type when extracting the mappings. Addresses elastic#36811.
Collaborator
|
Pinging @elastic/es-search |
Contributor
Author
|
@jpountz this really didn't turn out as cleanly as I hoped -- feel free to make changes, or open a new PR instead. |
jpountz
approved these changes
Jan 15, 2019
Contributor
jpountz
left a comment
There was a problem hiding this comment.
This looks good to me, I don't have better ideas... Thanks for tackling it!
Contributor
Author
|
Thanks for the review! As a note I filed #37450 to track cleaning up the overall approach. |
48 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #36811.