(WIP) Implement geo_grid aggregation#37277
Closed
nyurik wants to merge 9 commits intoelastic:masterfrom
Closed
Conversation
Collaborator
|
Pinging @elastic/es-analytics-geo |
3 tasks
Contributor
Author
|
Done in #37842 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR has been superseded by #37842
Reworked #30320 PR
This PR adds a new
geo_gridaggregation designed to eventually replace thegeohash_gridaggregation. It has identical parameters asgeohash_grid, but also requires ahash_typeparameter to indicate which algorithm to use. There is no defaults.The first PR adds the
geohashalgorithm, but a follow up will add the tile-based (quadkey - #30240 )Minor interface change:
getKey()andgetKeyAsString()return the same string for the new type of bucket.TODO
ParsedGeoGridChanges from #30320
geohash_grid, but instead add a newgeo_grid(copies most of the existing code), and deprecategeohash_grid.geo_gridwill requirehash_typeparameter. Setting it to"geohash"makes it behave the same as thegeohash_grid.hash_typeis implemented as a string instead of an Enum. This allows for a more flexible addition of the new algorithms.geohash_grid