Make remote ping and compress settings dynamic#37200
Make remote ping and compress settings dynamic#37200Tim-Brooks merged 2 commits intoelastic:masterfrom
Conversation
Traditionally remote clusters can be configured dynamically. However, the compress and ping settings are not currently set to be configured dynamically. This commit changes that.
|
Pinging @elastic/es-distributed |
|
I have opened #37201 to track additional work we might want done in this area. |
|
@dliappis I did not get a review for this today, so I was not able to merge it. But if it looks good to you, you can merge it. If you do, just mark the backport pending. And I will backport it. |
jasontedor
left a comment
There was a problem hiding this comment.
LGTM. Let's follow-up with responding to changes in these settings on an existing remote cluster.
|
Also LGTM from me, thanks @tbrooks8 ; I have tested it on |
|
heya I was looking at this with @dliappis and we don't see the setting being applied, even when specified while registering a new cluster. I understand from the description that it's expected that the setting does not currently get updated for existing clusters (as there is no consumer), but I would expect it to be applied to a newly built connection profile created when registering a new cluster. This should be reproducible with a unit test. |
|
Yeah it looks like there will be more steps involved to use the dynamic settings when adding a remote cluster. I marked the related issue as a bug and it will be fixed with that. |
Traditionally remote clusters can be configured dynamically. However,
the compress and ping settings are not currently set to be configured
dynamically. This commit changes that.