[ML] Create the ml-config index#36608
Closed
davidkyle wants to merge 12 commits intoelastic:feature-jindex-6xfrom
Closed
[ML] Create the ml-config index#36608davidkyle wants to merge 12 commits intoelastic:feature-jindex-6xfrom
davidkyle wants to merge 12 commits intoelastic:feature-jindex-6xfrom
Conversation
Collaborator
|
Pinging @elastic/ml-core |
13d67ca to
5a74edf
Compare
43 tasks
e0e73a1 to
fabe447
Compare
fabe447 to
3f607d7
Compare
Member
Author
|
Retest this please |
Contributor
dimitris-athanasiou
left a comment
There was a problem hiding this comment.
Left a few comments.
| private static final Logger logger = LogManager.getLogger(MlConfigMigrator.class); | ||
|
|
||
| public static final String MIGRATED_FROM_VERSION = "migrated from version"; | ||
| public static final int CONFIG_INDEX_MAX_RESULTS_WINDOW = 10_000; |
Contributor
There was a problem hiding this comment.
This setting is misplaced here. Could you move it to AnomalyDetectorsIndex please?
Contributor
There was a problem hiding this comment.
Also, we should take the chance and raise this to 100K?
| * datafeed configuration document | ||
| * | ||
| * The number of datafeeds returned in a search it limited to | ||
| * {@link MlConfigMigrator#CONFIG_INDEX_MAX_RESULTS_WINDOW}. |
Contributor
There was a problem hiding this comment.
This will need updating once the setting is moved.
| * anomaly detector job configuration document | ||
| * | ||
| * The number of jobs returned in a search it limited to | ||
| * {@link MlConfigMigrator#CONFIG_INDEX_MAX_RESULTS_WINDOW}. |
Contributor
There was a problem hiding this comment.
This will need updating once the setting is moved.
Member
Author
|
run gradle build tests 2 |
Member
Author
|
Closing as #36792 replaces this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create the
.ml-configindex in the migrator class if it does not exist and require the existence of the index for the jobs/datafeeds are eligible to be migrated checks. The index is created only if there are job and datafeed configs to migrate.The created index has
index.max_result_windowexplicitly set to 10,000 and the template has the same setting. The classes that search the index for configs use that value to set the search size.Addressed #34864