[ZEN2] Use Zen2 in REST Tests#36300
Merged
original-brownbear merged 13 commits intoelastic:masterfrom Dec 7, 2018
original-brownbear:zen2-in-rest-tests
Merged
[ZEN2] Use Zen2 in REST Tests#36300original-brownbear merged 13 commits intoelastic:masterfrom original-brownbear:zen2-in-rest-tests
original-brownbear merged 13 commits intoelastic:masterfrom
original-brownbear:zen2-in-rest-tests
Conversation
Collaborator
|
Pinging @elastic/es-distributed |
server/src/main/java/org/elasticsearch/cluster/coordination/ClusterBootstrapService.java
Show resolved
Hide resolved
DaveCTurner
reviewed
Dec 6, 2018
Member
DaveCTurner
left a comment
There was a problem hiding this comment.
Great. I left a few questions.
buildSrc/src/main/groovy/org/elasticsearch/gradle/test/ClusterFormationTasks.groovy
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/cluster/coordination/ClusterBootstrapService.java
Show resolved
Hide resolved
Contributor
Author
Set to what though? Do you want to set the property in the test settings and revert the code change to prod. code or do you want to actively set a value ( |
DaveCTurner
reviewed
Dec 6, 2018
server/src/main/java/org/elasticsearch/cluster/coordination/ClusterBootstrapService.java
Show resolved
Hide resolved
Contributor
Author
|
Jenkins test this |
Contributor
|
@elasticmachine retest this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.