Register CcrRepository based on settings update (#36086)#36277
Merged
Tim-Brooks merged 10 commits intoelastic:6.xfrom Dec 7, 2018
Merged
Register CcrRepository based on settings update (#36086)#36277Tim-Brooks merged 10 commits intoelastic:6.xfrom
Tim-Brooks merged 10 commits intoelastic:6.xfrom
Conversation
This commit adds an empty CcrRepository snapshot/restore repository. When a new cluster is registered in the remote cluster settings, a new CcrRepository is registered for that cluster. This is implemented using a new concept of "internal repositories". RepositoryPlugin now allows implementations to return factories for "internal repositories". The "internal repositories" are different from normal repositories in that they cannot be registered through the external repository api. Additionally, "internal repositories" are local to a node and are not stored in the cluster state. The repository will be unregistered if the remote cluster is removed.
Collaborator
|
Pinging @elastic/es-distributed |
Contributor
Author
|
@ywelsch - This back port required some substantive changes due to modifications needed for the actions. Can you give it a review? |
ywelsch
suggested changes
Dec 6, 2018
Contributor
ywelsch
left a comment
There was a problem hiding this comment.
If you subclass GenericAction instead, I think you can avoid the whole RequestBuilder stuff and the code will look pretty much like on master (and fields still final)
Contributor
Author
I have made these changes. Thanks for pointing out that base class. I have not done a lot of work related to back porting actions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds an empty CcrRepository snapshot/restore repository.
When a new cluster is registered in the remote cluster settings, a new
CcrRepository is registered for that cluster.
This is implemented using a new concept of "internal repositories".
RepositoryPlugin now allows implementations to return factories for
"internal repositories". The "internal repositories" are different from
normal repositories in that they cannot be registered through the
external repository api. Additionally, "internal repositories" are local
to a node and are not stored in the cluster state.
The repository will be unregistered if the remote cluster is removed.