Skip to content

Deprecation check for tribe node#36240

Merged
AthenaEryma merged 7 commits intoelastic:6.xfrom
AthenaEryma:depcheck/tribe
Dec 10, 2018
Merged

Deprecation check for tribe node#36240
AthenaEryma merged 7 commits intoelastic:6.xfrom
AthenaEryma:depcheck/tribe

Conversation

@AthenaEryma
Copy link
Copy Markdown
Contributor

Adds a deprecation check for tribe node.

Relates to #36024 and #28443

@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-core-features

return new DeprecationIssue(DeprecationIssue.Level.CRITICAL,
"Tribe Node removed in favor of Cross Cluster Search",
"https://www.elastic.co/guide/en/elasticsearch/reference/master/breaking_70_cluster_changes.html" +
"#_tribe_node_removed",
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link should work once #36239 is merged.

@AthenaEryma
Copy link
Copy Markdown
Contributor Author

These test failures appear to be due to the BWC problems around 5.6.15.

@elasticmachine test this please

Copy link
Copy Markdown
Contributor

@s1monw s1monw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AthenaEryma
Copy link
Copy Markdown
Contributor Author

AthenaEryma commented Dec 7, 2018

Failure does not reproduce locally and appears unrelated.
@elasticmachine run gradle build tests 1

@AthenaEryma AthenaEryma merged commit 50a3dfa into elastic:6.x Dec 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants