[Zen2] Best-effort cluster formation if unconfigured#36215
Merged
DaveCTurner merged 20 commits intoelastic:masterfrom Dec 7, 2018
Merged
Conversation
In real deployments it is important that clusters are properly configured to avoid accidentally forming multiple independent clusters at cluster bootstrapping time. However we also expect to be able to unpack Elasticsearch and start up one or more nodes without any up-front configuration, and have them do their best to find each other and form a cluster after a few seconds. This change adds a delayed automatic bootstrapping process to nodes that start up with no relevant settings set to support the desired out-of-the-box experience without compromising safety in properly-configured deployments.
Collaborator
|
Pinging @elastic/es-distributed |
ywelsch
reviewed
Dec 4, 2018
Contributor
ywelsch
left a comment
There was a problem hiding this comment.
A few minor comments, looks good o.w.
server/src/test/java/org/elasticsearch/cluster/coordination/ClusterBootstrapServiceTests.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/cluster/coordination/ClusterBootstrapService.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/cluster/coordination/ClusterBootstrapService.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/cluster/coordination/ClusterBootstrapService.java
Outdated
Show resolved
Hide resolved
61 tasks
DaveCTurner
commented
Dec 5, 2018
ywelsch
suggested changes
Dec 6, 2018
server/src/main/java/org/elasticsearch/bootstrap/BootstrapChecks.java
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| if (unconfiguredBootstrapTimeout != null) { | ||
| logger.info("no discovery configuration found, will perform best-effort cluster bootstrapping after [{}] " + |
Contributor
There was a problem hiding this comment.
can we avoid this message if the cluster is already bootstrapped?
Member
Author
There was a problem hiding this comment.
We can avoid the whole cluster bootstrap service in that case. I pushed 43fdbd0.
Member
Author
|
@elasticmachine please run the Gradle build tests 2 |
This was referenced Dec 14, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In real deployments it is important that clusters are properly configured to
avoid accidentally forming multiple independent clusters at cluster
bootstrapping time. However we also expect to be able to unpack Elasticsearch
and start up one or more nodes without any up-front configuration, and have
them do their best to find each other and form a cluster after a few seconds.
This change adds a delayed automatic bootstrapping process to nodes that start
up with no relevant settings set to support the desired out-of-the-box
experience without compromising safety in properly-configured deployments.