[Zen2] Remove AbstractComponent usage#35483
Merged
DaveCTurner merged 3 commits intoelastic:zen2from Nov 13, 2018
Merged
Conversation
AbstractComponent was deprecated in elastic#35140 and is looking like it will be removed at some point by elastic#34888. Today all it does is provide a logger. This change removes the usages of AbstractComponent that live solely in the zen2 feature branch to avoid some future merge pain, and replaces it where necessary with some directly-created loggers.
Collaborator
|
Pinging @elastic/es-distributed |
ywelsch
reviewed
Nov 13, 2018
server/src/main/java/org/elasticsearch/cluster/coordination/CoordinationState.java
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AbstractComponentwas deprecated in #35140 and is looking like it will beremoved at some point by #34888. Today all it does is provide a logger. This
change removes the usages of
AbstractComponentthat live solely in thezen2feature branch to avoid some future merge pain, and replaces it where necessary
with some directly-created loggers.