HLRC: Update Delete Role to use Optional#35470
Closed
hub-cap wants to merge 2 commits intoelastic:masterfrom
Closed
HLRC: Update Delete Role to use Optional#35470hub-cap wants to merge 2 commits intoelastic:masterfrom
hub-cap wants to merge 2 commits intoelastic:masterfrom
Conversation
Remove the old boolean found logic in DeleteRoleResponse and use Optional instead as the return type.
Collaborator
|
Pinging @elastic/es-core-infra |
iverase
approved these changes
Nov 12, 2018
Contributor
iverase
left a comment
There was a problem hiding this comment.
Response test does not provide anything new. LGTM
Contributor
Author
|
Im closing this as a delete should not use optional, but instead throw up if its not found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the old boolean found logic in DeleteRoleResponse and use
Optional instead as the return type.