Discovery EC2: Utilize Amazon SDK to resolve EC2 metadata server#35246
Merged
vladimirdolzhenko merged 2 commits intoelastic:masterfrom Nov 5, 2018
Merged
Discovery EC2: Utilize Amazon SDK to resolve EC2 metadata server#35246vladimirdolzhenko merged 2 commits intoelastic:masterfrom
vladimirdolzhenko merged 2 commits intoelastic:masterfrom
Conversation
Collaborator
|
Pinging @elastic/es-distributed |
…test nature of the task
Contributor
Author
|
thanks @tlrx for review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discovery EC2 uses hard coded url for EC2 metadata server
http://169.254.169.254/. It makes some difficulties on testing like #35141With this PR discovery-ec2 uses Amazon SDK to resolve metadata server, improves unit and integration testing and aligns with approach used in repositoty-s3.
Closes #35141