Merged
Conversation
Collaborator
|
Pinging @elastic/es-core-infra |
cbuescher
requested changes
Oct 29, 2018
Member
cbuescher
left a comment
There was a problem hiding this comment.
I left a few minor comments, looks good otherwise.
| = new ConstructingObjectParser<>("delete_rollup_job_response", true, | ||
| args -> new DeleteRollupJobResponse((boolean) args[0])); | ||
| static { | ||
| PARSER.declareBoolean(constructorArg(), new ParseField("acknowledged")); |
Member
There was a problem hiding this comment.
nit: I changed this on master to get the parser from AcknowledgedResponse using a new generateParser method that I introduced there on request of Baz. Maybe we could use the same here in the backport to make it match the version on master.
| = new ConstructingObjectParser<>("put_rollup_job_response", true, args -> new PutRollupJobResponse((boolean) args[0])); | ||
| static { | ||
| PARSER.declareBoolean(constructorArg(), new ParseField("acknowledged")); | ||
| } |
Member
There was a problem hiding this comment.
same here: I'd like to keep the version using generateParser since its the same as in master.
|
|
||
|
|
||
| :upid: {mainid}-rollup | ||
| :doc-tests-file: {doc-tests}/RollupDocumentationIT.java |
Member
There was a problem hiding this comment.
duplication from line 299/300
Contributor
Author
|
@cbuescher no rush, but I believe I have addressed your comments and this is ready for re-review. thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR backports delete job from
masterto6.xbranch.