test this please

test this please

@javanna
Thank you for reminding.
But this class is just used to show the snippets in document and I could not find a test class of it.
Did you mean that I need add one?

17:44:50 [ant:checkstyle] [ERROR] /var/lib/jenkins/workspace/elastic+elasticsearch+pull-request/client/rest/src/test/java/org/elasticsearch/client/documentation/RestClientDocumentation.java:81: Code snippets longer than 76 characters get cut off when rendered in the docs [SnippetLength]
17:44:50 > Task :client:rest:checkstyleTest FAILED
17:44:50
17:44:50 FAILURE: Build failed with an exception.

It seems that something wrong with the Code snippet length in RestClientDocumentation.java,
Java class format is according to java-language-formatting-guidelines.
I'm thinking of submiting an issue to add a rule of Java class for code snippet .
Or someone fixes the CI scripts.
Can someone tell me what I should do.

hi @wangzhenhui1992 sorry about the confusion, "test this please" is a comment to trigger a build through our jenkins bot :)

The build failed because of a style check, as the line is now too long and would not be nicely displayed in our docs. The problem is that HttpAsyncResponseConsumerFactory.HeapBufferedResponseConsumerFactory is too long alone to fit nicely in our docs. I wonder if we should not make this change then. Thoughts @nik9000 ?

@javanna @nik9000
What about defining 30 * 1024 * 1024 * 1024 as an variable named size and it will go like this?

private static final RequestOptions COMMON_OPTIONS;
static {
    RequestOptions.Builder builder = RequestOptions.DEFAULT.toBuilder();
    builder.addHeader("Authorization", "Bearer " + TOKEN); 
    int size = 30 * 1024 * 1024 * 1024;
    builder.setHttpAsyncResponseConsumerFactory(           
        new HttpAsyncResponseConsumerFactory.HeapBufferedResponseConsumerFactory(size));
    COMMON_OPTIONS = builder.build();
}

And another one : Adding a return code before 30 * 1024 * 1024 * 1024 like below

private static final RequestOptions COMMON_OPTIONS;
static {
    RequestOptions.Builder builder = RequestOptions.DEFAULT.toBuilder();
    builder.addHeader("Authorization", "Bearer " + TOKEN); 
    builder.setHttpAsyncResponseConsumerFactory(           
        new HttpAsyncResponseConsumerFactory.HeapBufferedResponseConsumerFactory(
            30 * 1024 * 1024 * 1024));
    COMMON_OPTIONS = builder.build();
}

retest this please

retest this please

@javanna Can I trigger it ?

retest this please

Pinging @elastic/es-core-infra

@wangzhenhui1992 only people in the elastic organization can trigger a test build. We are happy to do it for you :)

hi @wangzhenhui1992 would you mind merging master in? Sorry for the trouble, I think some of the failures we are getting here are due to problems that have now been solved on master.

Sorry about not commenting earlier. The change is fine with me so long as the line length checker likes it. We really don't have much room on those snippets.

Pinging @elastic/es-docs

@wangzhenhui1992 only people in the elastic organization can trigger a test build. We are happy to do it for you :)

@hub-cap Thank you

Sorry about not commenting earlier. The change is fine with me so long as the line length checker likes it. We really don't have much room on those snippets.

@nik9000 Thank you

hi @wangzhenhui1992 would you mind merging master in? Sorry for the trouble, I think some of the failures we are getting here are due to problems that have now been solved on master.

@javanna Of course OK. Let me have a try and then I will mention you with the PR.

Closed in favour of #34834