SQL: Fix negation of equals comparison.#34680
Closed
matriv wants to merge 1 commit intoelastic:masterfrom
Closed
Conversation
For other logical operators adding `NOT` in front of the expression results in negation of the binary operator, e.g.: `NOT a > b` becomes `a <= b` but this is not the case for `NOT a = b`. This implements the negation of equals when encountered in the SELECT clause or needs to be translated to a painless script (e.g.: `HAVING NOT count(*) = 10`) Previously, an `SqlIllegalArgumentException[Not supported yet]` was thrown. Fixes: elastic#34558
Collaborator
|
Pinging @elastic/es-search-aggs |
Contributor
Author
|
@costin @astefan I'm working on an alternative fix but struggling with null safety here: matriv@f4eedc4 |
Contributor
Author
|
retest this please |
Contributor
Author
|
superseded by #34877 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For other logical operators adding
NOTin front of the expressionresults in negation of the binary operator, e.g.:
NOT a > bbecomesa <= bbut this is not the case for
NOT a = b.This implements the negation of equals when encountered in the SELECT
clause or needs to be translated to a painless script (e.g.:
HAVING NOT count(*) = 10)Previously, an
SqlIllegalArgumentException[Not supported yet]wasthrown.
Fixes: #34558