Skip to content

Fix inner_hits retrieval when stored fields are disabled#34652

Merged
jimczi merged 2 commits intoelastic:6.xfrom
jimczi:inner_hits_disable_stored_fields_6x
Oct 24, 2018
Merged

Fix inner_hits retrieval when stored fields are disabled#34652
jimczi merged 2 commits intoelastic:6.xfrom
jimczi:inner_hits_disable_stored_fields_6x

Conversation

@jimczi
Copy link
Copy Markdown
Contributor

@jimczi jimczi commented Oct 19, 2018

This is the backport of #33018, a change was needed to handle indices with multiple types.
This change throws an error if stored fields are disabled on inner_hits for an index with multiple types

Closes #32941

This is the backport of elastic#33018, a change was needed to handle indices with multiple types.
This change throws an error if stored fields are disabled on `inner_hits` for an index with multiple types

Closes elastic#32941
@jimczi jimczi added >bug :Search/Search Search-related issues that do not fall into other categories v6.5.0 labels Oct 19, 2018
@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-search-aggs

@jimczi
Copy link
Copy Markdown
Contributor Author

jimczi commented Oct 19, 2018

\cc @astefan

Copy link
Copy Markdown
Member

@cbuescher cbuescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jimczi jimczi merged commit a0a7032 into elastic:6.x Oct 24, 2018
@jimczi jimczi deleted the inner_hits_disable_stored_fields_6x branch October 24, 2018 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>bug :Search/Search Search-related issues that do not fall into other categories v6.5.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants