[HLRC] Update Set Policy API to use Validatable#34248
Closed
AthenaEryma wants to merge 1 commit intoelastic:index-lifecyclefrom
Closed
[HLRC] Update Set Policy API to use Validatable#34248AthenaEryma wants to merge 1 commit intoelastic:index-lifecyclefrom
AthenaEryma wants to merge 1 commit intoelastic:index-lifecyclefrom
Conversation
Also reworks the tests for the Set Policy response object to use the new XContent testing capabilities, rather than having to implement ToXContent on the response object itself.
Collaborator
|
Pinging @elastic/es-core-infra |
13 tasks
dakrone
approved these changes
Oct 2, 2018
Member
dakrone
left a comment
There was a problem hiding this comment.
LGTM, left one comment about copyInstance
|
|
||
| private SetIndexLifecyclePolicyRequest copyInstance(final SetIndexLifecyclePolicyRequest original) { | ||
| SetIndexLifecyclePolicyRequest copy = new SetIndexLifecyclePolicyRequest(original.policy(), original.indices()); | ||
| copy.indicesOptions(original.indicesOptions()); |
Member
There was a problem hiding this comment.
Doesn't this need to copy the timeouts also?
Contributor
Author
There was a problem hiding this comment.
It probably should to be strictly correct, but this made me check (since obviously this doesn't make the equals() test fail) and as far as I can tell, no (or very, very few) *Request classes that inherit the timeout parameters from a superclass check them in the .equals() method. Is that something we should be concerned about?
(cc @hub-cap)
Contributor
Author
|
Closing this PR as this API is being removed by #34304 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also reworks the tests for the Set Policy response object to use the new
XContent testing capabilities, rather than having to implement
ToXContent on the response object itself.