Back porting Completion types with multi-fields support (#34081)#34228
Merged
pgomulka merged 2 commits intoelastic:6.xfrom Oct 3, 2018
Merged
Back porting Completion types with multi-fields support (#34081)#34228pgomulka merged 2 commits intoelastic:6.xfrom
pgomulka merged 2 commits intoelastic:6.xfrom
Conversation
Mappings with completion type and multi-fields, were not able to index array or object format on completion fields. Only string format was supported. This is fixed by providing multiField parser with externalValueContext with already parsed object closes elastic#15115
Member
|
@pgomulka you should probably edit the subject. Sometimes folks open up PRs by accident with subjects with similar names. |
Contributor
Author
|
@nik9000 sorry for that. Forgot to edit the subject when creating and it ended up like that automatically. Updated just now |
Contributor
Author
|
relates #34081 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to back port from master.
Review not needed
relates #15115