[ML-Dataframe] Use AsyncTwoPhaseIndexer#33504
Merged
hendrikmuhs merged 4 commits intoelastic:feature/fibfrom Sep 10, 2018
Merged
[ML-Dataframe] Use AsyncTwoPhaseIndexer#33504hendrikmuhs merged 4 commits intoelastic:feature/fibfrom
hendrikmuhs merged 4 commits intoelastic:feature/fibfrom
Conversation
Collaborator
|
Pinging @elastic/ml-core |
droberts195
approved these changes
Sep 7, 2018
droberts195
left a comment
There was a problem hiding this comment.
LGTM
I just left one suggestion about an exception type.
| bulkIndexRequest.add(new IndexRequest(PIVOT_INDEX, DOC_TYPE).source(builder)); | ||
|
|
||
| } catch (IOException e) { | ||
| throw new RuntimeException(e); |
There was a problem hiding this comment.
There is a class called UncheckedIOException that might be better here, as it's clearer to the handling code that it should be unwrapped.
added 2 commits
September 7, 2018 16:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FEATURE BRANCH PR
Replace mocked indexer and use AsyncTwoPhaseIndexer (introduced in #32743) instead.
Note: Inner operations are still mocked, although the destination index now uses the job id as a suffix.