MockTcpTransport to connect asynchronously (#28203)#33476
Merged
Tim-Brooks merged 2 commits intoelastic:6.xfrom Sep 6, 2018
Merged
MockTcpTransport to connect asynchronously (#28203)#33476Tim-Brooks merged 2 commits intoelastic:6.xfrom
MockTcpTransport to connect asynchronously (#28203)#33476Tim-Brooks merged 2 commits intoelastic:6.xfrom
Conversation
The method `initiateChannel` on `TcpTransport` is explicit in that channels can be connect asynchronously. All production implementations do connect asynchronously. Only the blocking `MockTcpTransport` connects in a synchronous manner. This avoids testing some of the blocking code in `TcpTransport` that waits on connections to complete. Additionally, it requires a more extensive method signature than required for other transports. This commit modifies the `MockTcpTransport` to make these connections asynchronously on a different thread. Additionally, it simplifies that `initiateChannel` method signature.
Collaborator
|
Pinging @elastic/es-core-infra |
Contributor
Author
|
This is just a backport. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The method
initiateChannelonTcpTransportis explicit in thatchannels can be connect asynchronously. All production implementations
do connect asynchronously. Only the blocking
MockTcpTransportconnects in a synchronous manner. This avoids testing some of the
blocking code in
TcpTransportthat waits on connections to complete.Additionally, it requires a more extensive method signature than
required for other transports.
This commit modifies the
MockTcpTransportto make these connectionsasynchronously on a different thread. Additionally, it simplifies that
initiateChannelmethod signature.