TESTS: Fix Race Condition in Temp Path Creation (#33352)#33370
Merged
original-brownbear merged 1 commit intoelastic:6.xfrom Sep 4, 2018
original-brownbear:33344-6.x
Merged
TESTS: Fix Race Condition in Temp Path Creation (#33352)#33370original-brownbear merged 1 commit intoelastic:6.xfrom original-brownbear:33344-6.x
original-brownbear merged 1 commit intoelastic:6.xfrom
original-brownbear:33344-6.x
Conversation
* TESTS: Fix Race Condition in Temp Path Creation * Calling `createTempDir` concurrently here in the `Follower`s causes collisions at times which lead to `createEngine` throwing because of unexpected files in the newly created temp dir * Fixed by creating all temp dirs in the main test thread * closes #33344
Collaborator
|
Pinging @elastic/es-distributed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TESTS: Fix Race Condition in Temp Path Creation
Calling
createTempDirconcurrently here inthe
Followers causes collisions at timeswhich lead to
createEnginethrowing becauseof unexpected files in the newly created temp
dir
closes [CI] LuceneChangesSnapshotTests#testUpdateAndReadChangesConcurrently fails #33344
Backport PR just to run Jenkins