INGEST: Simplify IngestService (#33008)#33314
Merged
original-brownbear merged 6 commits intoelastic:6.xfrom Sep 4, 2018
original-brownbear:33008-6.x
Merged
INGEST: Simplify IngestService (#33008)#33314original-brownbear merged 6 commits intoelastic:6.xfrom original-brownbear:33008-6.x
original-brownbear merged 6 commits intoelastic:6.xfrom
original-brownbear:33008-6.x
Conversation
* INGEST: Simplify IngestService * Follow up to #32617 * Flatten redundant inner classes of `IngestService`
Collaborator
|
Pinging @elastic/es-core-infra |
Contributor
Author
|
@martijnvg sorry for this one (I know it's quite the annoying review), but can you give this another pair of eyes please when you get a chance? I had to make some adjustments to things from |
Contributor
Author
|
@martijnvg thanks so much! Merging :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
INGEST: Simplify IngestService
Follow up to INGEST: Move all Pipeline State into IngestService #32617
Flatten redundant inner classes of
IngestServiceBackport of #33008 and #32617 (had to do it in one go or at least figured that would be easier here, since both commits were conflicting anyway)