Reduce connections used by MockNioTransport#32620
Merged
Tim-Brooks merged 3 commits intoelastic:masterfrom Aug 7, 2018
Merged
Conversation
The MockNioTransport (similar to the MockTcpTransport) is used for integ tests. The MockTcpTransport has always only opened a single for all of its work. The MockNioTransport has awlays opened the default number of connections (13). This means that every test where two transports connect requires 26 connections. This is more than is necessary. This commit modifies the MockNioTransport to only require 3 connections.
Collaborator
|
Pinging @elastic/es-core-infra |
jasontedor
requested changes
Aug 6, 2018
|
|
||
| @Override | ||
| protected ConnectionProfile resolveConnectionProfile(ConnectionProfile connectionProfile) { | ||
| ConnectionProfile connectionProfile1 = resolveConnectionProfile(connectionProfile, defaultConnectionProfile); |
Member
There was a problem hiding this comment.
Can you give it a more meaningful name?
| ConnectionProfile.Builder builder = new ConnectionProfile.Builder(); | ||
| Set<TransportRequestOptions.Type> allTypesWithConnection = new HashSet<>(); | ||
| Set<TransportRequestOptions.Type> allTypesWithoutConnection = new HashSet<>(); | ||
| for (TransportRequestOptions.Type type :TransportRequestOptions.Type.values()) { |
| return transportService; | ||
| } | ||
|
|
||
| protected int channelsPerNodeConnection() { |
Contributor
Author
|
@jasontedor - I made changes based on your review. |
Member
Great, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MockNioTransport (similar to the MockTcpTransport) is used for integ
tests. The MockTcpTransport has always only opened a single for all of
its work. The MockNioTransport has awlays opened the default number of
connections (13). This means that every test where two transports
connect requires 26 connections. This is more than is necessary. This
commit modifies the MockNioTransport to only require 3 connections.