Support "source" parameter in _has_privileges#32310
Merged
tvernum merged 1 commit intoelastic:security-app-privsfrom Jul 24, 2018
Merged
Support "source" parameter in _has_privileges#32310tvernum merged 1 commit intoelastic:security-app-privsfrom
tvernum merged 1 commit intoelastic:security-app-privsfrom
Conversation
The rest tests require that any request that supports GET with body must also support GET with source="..." This changes the _has_privileges rest action to support the source parameter as an alternative to reading a body
Collaborator
|
Pinging @elastic/es-security |
Contributor
Author
|
Prior to this fix, the following test would fail: Following this change, that test/seed now passes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rest tests require that any request that supports GET with body
must also support GET with source="..."
This changes the _has_privileges rest action to support the source
parameter as an alternative to reading a body