Restrict authorizing_realms to platinum only#32115
Merged
tvernum merged 2 commits intoelastic:security-lookup-realmsfrom Jul 18, 2018
Merged
Restrict authorizing_realms to platinum only#32115tvernum merged 2 commits intoelastic:security-lookup-realmsfrom
tvernum merged 2 commits intoelastic:security-lookup-realmsfrom
Conversation
Collaborator
|
Pinging @elastic/es-security |
jaymode
approved these changes
Jul 17, 2018
| */ | ||
| public boolean isAuthorizingRealmAllowed() { | ||
| final Status localStatus = status; | ||
| return (localStatus.mode == OperationMode.PLATINUM || localStatus.mode == OperationMode.TRIAL ) |
Member
There was a problem hiding this comment.
nit exta space between TRIAL and )
bizybot
reviewed
Jul 18, 2018
| /** | ||
| * @return whether "authorizing_realms" are allowed based on the license {@link OperationMode} | ||
| */ | ||
| public boolean isAuthorizingRealmAllowed() { |
Contributor
There was a problem hiding this comment.
Pardon my knowledge with licensing, I just wanted to check if we have some encrypted data about what features are available in the license or we allow/disallow based on these checks depending on the license mode?
Contributor
Author
There was a problem hiding this comment.
We rely solely on the license "mode"
That way we can introduce new features without needing to reissue licenses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes "authorizing_realms" a platinum (or trial) feature.
If the license is not compliant, then any attempt to authenticate will
fail in the same way that "cannot find lookup user" fails, but with a
"license not compliant" message.