Skip to content

Add test for merging roles#32008

Merged
tvernum merged 2 commits intoelastic:security-app-privsfrom
tvernum:app-priv/test/composite-roles-merge
Jul 16, 2018
Merged

Add test for merging roles#32008
tvernum merged 2 commits intoelastic:security-app-privsfrom
tvernum:app-priv/test/composite-roles-merge

Conversation

@tvernum
Copy link
Copy Markdown
Contributor

@tvernum tvernum commented Jul 12, 2018

This commit adds a test for the most basic function of the CompositeRolesStore which is to merge 2 simple role descriptors into a single role.
There were a lot of tests around FLS/DLS and custom roles providers, but nothing for the most simple case.
This test will be extended to test the merging of conditional (OLS) cluster privileges once they exist on role descriptors.

@tvernum tvernum added >test Issues or PRs that are addressing/adding tests review :Security/Authorization Roles, Privileges, DLS/FLS, RBAC/ABAC labels Jul 12, 2018
@tvernum tvernum requested a review from albertzaharovits July 12, 2018 13:48
@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-security

@jkakavas jkakavas requested review from jkakavas and removed request for albertzaharovits July 16, 2018 04:42
Copy link
Copy Markdown
Contributor

@jkakavas jkakavas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tvernum tvernum merged commit 154eb1f into elastic:security-app-privs Jul 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Security/Authorization Roles, Privileges, DLS/FLS, RBAC/ABAC >test Issues or PRs that are addressing/adding tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants