Fix case sensitivity bug in application privileges#31491
Merged
tvernum merged 3 commits intoelastic:security-app-privsfrom Jun 26, 2018
Merged
Fix case sensitivity bug in application privileges#31491tvernum merged 3 commits intoelastic:security-app-privsfrom
tvernum merged 3 commits intoelastic:security-app-privsfrom
Conversation
The was a spurious toLowerCase in the privilege check that was left over from a previous design approach
Collaborator
|
Pinging @elastic/es-security |
Contributor
Author
|
FYI @kobelb |
Contributor
Author
|
@albertzaharovits I offer 1 🍺 for this review ;) |
albertzaharovits
approved these changes
Jun 25, 2018
Contributor
albertzaharovits
left a comment
There was a problem hiding this comment.
LGTM neat and clean as usual, Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The was a spurious toLowerCase in the privilege check that was left
over from a previous design approach