Skip to content

Lazily retrieve EngineFactory based on IndexSettings#31409

Closed
dakrone wants to merge 2 commits intoelastic:masterfrom
dakrone:lazy-engine-factory-pluggability
Closed

Lazily retrieve EngineFactory based on IndexSettings#31409
dakrone wants to merge 2 commits intoelastic:masterfrom
dakrone:lazy-engine-factory-pluggability

Conversation

@dakrone
Copy link
Copy Markdown
Member

@dakrone dakrone commented Jun 18, 2018

This commit changes the way that EngineFactorys are returned, instead of the
EngineFactory being set at time of shard creation, this changes the pluggability
so that an existing IndexShard can return a different engine factory depending
on dynamic index settings.

Relates to #31141

@dakrone
Lazily retrieve EngineFactory based on IndexSettings
bd7a46f 
This commit changes the way that `EngineFactory`s are returned, instead of the
EngineFactory being set at time of shard creation, this changes the pluggability
so that an existing `IndexShard` can return a different engine factory depending
on dynamic index settings.

Relates to elastic#31141
@dakrone dakrone added review v7.0.0 :Distributed/Engine Anything around managing Lucene and the Translog in an open shard. v6.4.0 labels Jun 18, 2018
@elasticmachine
Copy link
Copy Markdown
Collaborator

elasticmachine commented Jun 18, 2018

Pinging @elastic/es-distributed

@bleskes
Copy link
Copy Markdown
Contributor

bleskes commented Jun 20, 2018

I would really like to try to avoid having an EngineFactoryFactory (effectively). Maybe we can change EngineFactory.newReadWriteEngine to get an index settings too?

@dakrone
Copy link
Copy Markdown
Member Author

dakrone commented Jun 20, 2018 •
edited
Loading

Maybe we can change EngineFactory.newReadWriteEngine to get an index settings too?

Sure, I think that might be an option, I'll make those changes. However, do we want to rename the method at the same time to just be newEngine(EngineConfig config)? It seems strange to me to be providing engines that may not be read/write from a method named "newReadWriteEngine"

@dakrone
Copy link
Copy Markdown
Member Author

dakrone commented Jun 20, 2018

Actually, it looks like this is already possible with the EngineConfig containing the settings. I'll look into doing what I need without this change.

@dakrone dakrone mentioned this pull request Jul 2, 2018
Closed
8 tasks
@dakrone
Copy link
Copy Markdown
Member Author

dakrone commented Jul 2, 2018

Okay, I think we can get away without this. I opened #31745 so I'm closing this for now.

@dakrone dakrone closed this Jul 2, 2018
@dakrone dakrone deleted the lazy-engine-factory-pluggability branch February 4, 2019 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

:Distributed/Engine Anything around managing Lucene and the Translog in an open shard. >non-issue v6.4.0 v7.0.0-beta1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dakrone @elasticmachine @bleskes @colings86 @lcawl