Remove setting copy settings on resize to false#30321
Closed
jasontedor wants to merge 1 commit intoelastic:masterfrom
Closed
Remove setting copy settings on resize to false#30321jasontedor wants to merge 1 commit intoelastic:masterfrom
jasontedor wants to merge 1 commit intoelastic:masterfrom
Conversation
As the copy_settings REST parameter and copySettings transport field was deprecated in 6.4.0 slated for removal in 8.0.0, this commit puts us farther down that path by: - defaulting copy settings to true - preventing settings copy settings to false
Contributor
|
@jasontedor This process for removal is a little different than I envisaged. I had thought that we would:
The worry I have with the approach in this PR is that it puts the hard break in 7.0 since there is no way of not copying settings so to me it seems that its the same as just removing the parameter in 7.0? |
Member
Author
|
@colings86 I am following the plan that we outlined here: #28347 I am fine with changing the plan, but I think the place for that discussion is the source issue. |
Contributor
|
@jasontedor I left a comment on #28347 with my comments from above so we can discuss. Sorry I didn't think about this and bring up the concern earlier |
Collaborator
|
Pinging @elastic/es-core-infra |
Member
Author
|
Superseded by #30404 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the copy_settings REST parameter and copySettings transport field was deprecated in 6.4.0 slated for removal in 8.0.0, this commit puts us farther down that path by:
Relates #28347, relates #30255