Conversation
Collaborator
|
Pinging @elastic/es-search-aggs |
This was referenced Apr 29, 2018
1 task
f0de2e8 to
c63ebaa
Compare
3 tasks
91745dd to
cfd1366
Compare
This patch should not introduce any changes in the existing ES behavior. Its only goal is to allow subsequent addition of various hashing algorithms, such as quadkey, pluscode, hex, ...
Contributor
|
@nyurik I think we should we close this? I'm assuming it needs to be refactored since we changed how geotile was implemented since this was open, and IIRC we don't have plans to work on pluscode in the near future? We can re-open if/when we decide to start working on pluscode, but for now it's probably fine to close so we don't have old stale PRs lingering. |
Contributor
Author
|
Closing as this needs to be refactored to support new base classes. |
Contributor
|
👍 thanks @nyurik! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is based on #30320, which adds support for multiple hashing algorithms. This PR adds the plus code support to geohash grid aggregation (see also devs docs).
Testing
To test manually, use the documentation example, and simply add
"type": "pluscode"to the request.TODO
"type": "pluscode". Alternatives:plus,pluscodes, ...?Why Plus Code
Plus codes can be searched in Google and Google maps, showing needed location.
They have a number of important advantages -
see extensive comparison with other hashing approaches.