Skip to content

removes apostrophe#29231

Closed
andrewbanchich wants to merge 1 commit intoelastic:6.2from
andrewbanchich:patch-10
Closed

removes apostrophe#29231
andrewbanchich wants to merge 1 commit intoelastic:6.2from
andrewbanchich:patch-10

Conversation

@andrewbanchich
Copy link
Copy Markdown

fixes incorrect punctuation

@elasticmachine
Copy link
Copy Markdown
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

1 similar comment
@elasticmachine
Copy link
Copy Markdown
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

Copy link
Copy Markdown
Member

@cbuescher cbuescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrewbanchich thanks, good point. I left a suggestion to even remove the formatting, if you agree can you push an update?


You can limit the documents by adding a type to the `source` or by adding a
query. This will only copy ++tweet++'s made by `kimchy` into `new_twitter`:
query. This will only copy ++tweet++s made by `kimchy` into `new_twitter`:
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can even remove the special formatting for "tweet". I think it was useful when this was still refering to the "tweet" type but since the example nor uses "_doc" it looks better in the result to simply write "tweets", or what do you think?

@andrewbanchich
Copy link
Copy Markdown
Author

Closing because it is included in #29232.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants