Skip to content

Backport PR 26985, upgrading indices with a custom similarity plugin#28795

Merged
rjernst merged 1 commit intoelastic:5.6from
thomas11:thkapple/5.6-backport-25350
Mar 1, 2018
Merged

Backport PR 26985, upgrading indices with a custom similarity plugin#28795
rjernst merged 1 commit intoelastic:5.6from
thomas11:thkapple/5.6-backport-25350

Conversation

@thomas11
Copy link
Copy Markdown
Contributor

This is a straightforward port of #26985 to the 5.6 branch. Quoting the original:

Fix upgrading indices which use a custom similarity plugin.
Use a fake similarity map that always returns a value in MetaDataIndexUpgradeService.checkMappingsCompatibility instead of an empty map.

Fix upgrading indices which use a custom similarity plugin.
Use a fake similarity map that always returns a value in
MetaDataIndexUpgradeService.checkMappingsCompatibility instead of
an empty map.
@elasticmachine
Copy link
Copy Markdown
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

1 similar comment
@elasticmachine
Copy link
Copy Markdown
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@rjernst
Copy link
Copy Markdown
Member

rjernst commented Feb 23, 2018

@elasticmachine test this please

@thomas11
Copy link
Copy Markdown
Contributor Author

01:53:27 Execution failed for task ':plugins:ingest-attachment:thirdPartyAudit'.
01:53:27 > Invalid exclusions, nothing is wrong with these classes: [javax/xml/bind/Marshaller.class, javax/xml/bind/helpers/DefaultValidationEventHandler.class]

Looks unrelated to this PR?

@rjernst
Copy link
Copy Markdown
Member

rjernst commented Feb 23, 2018

Yes, the failure is unrelated (it ran with java 9 instead of java 8). I will re-trigger once CI is fixed to run java 8 with all 5.6 PRs.

@thomas11
Copy link
Copy Markdown
Contributor Author

Hey @rjernst, pinging you as you suggested earlier :) Any news on the ES 5 CI build?

@rjernst
Copy link
Copy Markdown
Member

rjernst commented Mar 1, 2018

I'm told it should work now.

@elasticmachine test this please

@rjernst rjernst merged commit 781d830 into elastic:5.6 Mar 1, 2018
@rjernst
Copy link
Copy Markdown
Member

rjernst commented Mar 1, 2018

Thanks @thomas11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants