Add deprecation message for config prompt#28000
Conversation
|
I am not sure how to label something for deprecation... I also need some guidance on where the docs live so i can update those as well. github search failed me, but simple grep showed me the way... I found the docs |
jasontedor
left a comment
There was a problem hiding this comment.
I left a comment, I think we need to reword this slightly.
There was a problem hiding this comment.
I think this is a little misleading. Today prompting can be used on any setting, but not every setting is eligible for secure settings.
There was a problem hiding this comment.
Oh i was not aware of this! ty for this info. im also bumping this to 6.3
2ff77f7 to
0a4292d
Compare
|
Ive updated the PR to note that not all settings can be secure settings in the prompt'ing and docs. |
| } | ||
|
|
||
| terminal.println(Terminal.Verbosity.SILENT, | ||
| "Prompting for property values is deprecated in " + Version.CURRENT |
There was a problem hiding this comment.
Should this be hardcoded and reworded to "since X.Y.Z"?
| === Prompting for settings | ||
|
|
||
| NOTE: Prompting for settings is deprecated. Please use <<secure-settings>> | ||
| for sensitive property values. Not all properties can be converted to use |
| } | ||
|
|
||
| terminal.println(Terminal.Verbosity.SILENT, | ||
| "Prompting for property values is deprecated in " + Version.CURRENT |
jasontedor
left a comment
There was a problem hiding this comment.
LGTM (with the suggestions of @rjernst).
|
Pinging @elastic/es-core-infra |
relates #27216