Splits nio project into two for eclipse build only#27939
Merged
colings86 merged 2 commits intoelastic:masterfrom Dec 21, 2017
colings86:fix/eclipse-build-nio
Merged
Splits nio project into two for eclipse build only#27939colings86 merged 2 commits intoelastic:masterfrom colings86:fix/eclipse-build-nio
colings86 merged 2 commits intoelastic:masterfrom
colings86:fix/eclipse-build-nio
Conversation
#27801 introduced a new gradle project `:libs:elasticsearch-nio` which creates cyclical project dependencies when importingthe projects into Eclipse. This change applies the same trick as we have for the core project where, and building for Eclipse, splits the `:libs:elasticsearch-nio` project into `:libs:elasticsearch-nio` which points to `src/main` and `:libs:elasticsearch-nio-tests` which points to `src/test`. This prevents cyclical project dependencies in Eclipse arising from the fact that eclipse does not separate compile/runtime dependencies from test dependencies.
nik9000
approved these changes
Dec 21, 2017
Member
nik9000
left a comment
There was a problem hiding this comment.
Without this Eclipse goes crazy. With it Eclipse is fine. The fix looks like the other fixes we've made in the past for Eclipse. LGTM.
Contributor
Author
|
Thanks for the review @nik9000 |
Contributor
|
Thank you for fixing this @colings86. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#27801 introduced a new gradle project
:libs:elasticsearch-niowhich creates cyclical project dependencies when importing the projects into Eclipse.This change applies the same trick as we have for the core project where, and building for Eclipse, splits the
:libs:elasticsearch-nioproject into:libs:elasticsearch-niowhich points tosrc/mainand:libs:elasticsearch-nio-testswhich points tosrc/test. This prevents cyclical project dependencies in Eclipse arising from the fact that eclipse does not separate compile/runtime dependencies from test dependencies.