Reject the index_options parameter for numeric fields#26668
Merged
cbuescher merged 2 commits intoelastic:masterfrom Sep 25, 2017
Merged
Reject the index_options parameter for numeric fields#26668cbuescher merged 2 commits intoelastic:masterfrom
index_options parameter for numeric fields#26668cbuescher merged 2 commits intoelastic:masterfrom
Conversation
cbuescher
commented
Sep 15, 2017
Member
Author
There was a problem hiding this comment.
I will open a separate PR with deprecation logging instead of the error against the 6.x branches.
jpountz
approved these changes
Sep 25, 2017
Contributor
There was a problem hiding this comment.
Could we override the indexOptions method in the number field builder instead of introducing a new method?
Member
Author
There was a problem hiding this comment.
Sure, I changed this. Will wait for another CI run before I merge.
bfdc63e to
e6b1b72
Compare
26 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Numeric fields no longer support the
index_optionsparameter. This changes the parameterto be rejected in numeric field types after it was deprecated in 6.0.
Closes #21475