Add a maximum search request size.#26423
Conversation
This commit adds the `http.search.max_content_length` setting that is a safeguard against too large search requests. It applies to the search, msearch and template search APIs.
|
What is the user's expected outcome if |
I tend to like the fact that such a setting would catch more abuse cases than if we solely focused on the Would you be ok with fixing the potential confusion you mentioned with documentation? |
|
@jpountz do you plan on coming back to this? |
|
We chatted about this in FixitFriday and were uneasy with how broad but not necessarily specific this soft limit is. E.g. large search requests are often bad, but you can definitely have a large request which is perfectly reasonable (long field names + many simple aggregations + long agg names, etc). Jason's point about confusing overlap with request body size is a concern too. We decided it would be better to try and tackle bad queries through more specific mechanisms (breakers, better validation of queries after parsing, etc). Decided to close for now. |
This commit adds the
http.search.max_content_lengthsetting that is asafeguard against too large search requests. It applies to the search, msearch
and template search APIs.